add: upload reports as an artifact#37
Open
Rushabhshroff wants to merge 11 commits intobrowserstack:betafrom
Open
add: upload reports as an artifact#37Rushabhshroff wants to merge 11 commits intobrowserstack:betafrom
Rushabhshroff wants to merge 11 commits intobrowserstack:betafrom
Conversation
Rushabhshroff
commented
Aug 24, 2023
Rushabhshroff
commented
Aug 24, 2023
Rushabhshroff
commented
Aug 24, 2023
|
Do we want to commit |
Zemotacqy
reviewed
Aug 30, 2023
Member
Author
Yes, this is required for github actions to work. Docs. We use "@vercel/ncc" approach. |
Zemotacqy
suggested changes
Sep 5, 2023
Comment on lines
191
to
193
| } else if (framework === FRAMEWORKS.xcuitest) { | ||
| reportEndpoint = URLS.REPORT.xcuitest_resultbundle; | ||
| } else { |
There was a problem hiding this comment.
Can we please add a check to upload only when enableResultBundle param is set to true?
Zemotacqy
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for uploading reports as an artifact